Repository navigation
test: skip SuiteSparse under PkgEval and install GPU deps on demand - #357
Merged
Merged
Conversation
- Skip `suitesparse.jl` when `PKGEVAL=true`, since MatrixDepot cannot download matrices in the sandbox - Remove AMDGPU, CUDA and cuSPARSE from the test environment and `Pkg.add` them only for the GPU test group (compat bounds come from the weakdeps in the main Project.toml) Closes JuliaDiff#356 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NohyV4La3BYBZ9XYQEGrfw
gdalle
marked this pull request as ready for review
October 28, 2026 13:41
gdalle
approved these changes
Oct 28, 2026
Member
|
Tests are failing because of a SuiteSparse server issue |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
==========================================
- Coverage 46.22% 43.23% -3.00%
==========================================
Files 20 20
Lines 2533 2526 -7
==========================================
- Hits 1171 1092 -79
- Misses 1362 1434 +72 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR was generated by a coding agent, please disregard it until @gdalle has reviewed it.
Closes #356.
Changes
ENV["PKGEVAL"] == "true", because MatrixDepot downloads fail in the PkgEval sandbox (the 35 errored tests in the report).AMDGPU,CUDAandcuSPARSEare removed fromtest/Project.toml. WhenJULIA_SMC_TEST_GROUP == "GPU"(Buildkite),runtests.jlcallsPkg.addon them before loading anything. Their compat bounds still come from the weakdeps section of the mainProject.toml. CPU-only runs (GitHub Actions, PkgEval) no longer need to precompile GPUCompiler/LLVM.jl, so PkgEval should stop reporting a misleadingprecompilefailure.Pkgis added to the test deps.Local checks (Julia 1.13, no GPU)
PKGEVAL=trueCPU suite: 87116/87116 passed, SuiteSparse skipped, no GPU package installed.JULIA_SMC_TEST_GROUP=GPU: GPU packages installed and loaded, CUDA/ROCm testsets skipped since no device is available. The actual GPU tests still need Buildkite.Model: Claude Opus 5.5
🤖 Generated with Claude Code
https://claude.ai/code/session_01NohyV4La3BYBZ9XYQEGrfw